fix(storage): add WAL checkpoint on close and fallback for corrupted WAL#1
Merged
Conversation
…mbass agents from touching these files (anomalyco#24057)
…alyco#23770) Co-authored-by: rgs_ramp <rgs@ramp.com> Co-authored-by: Aiden Cline <63023139+rekram1-node@users.noreply.github.com>
…example placeholder (anomalyco#24105)
- Checkpoint WAL before closing to prevent corruption on crash - Wrap PRAGMA journal_mode=WAL in try-catch with fallback to DELETE mode - Fixes crash on open when WAL is in inconsistent state from previous crash
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes crash on open when SQLite WAL is in inconsistent state from previous crash.
Changes
PRAGMA wal_checkpoint(TRUNCATE)before closing the database to ensure WAL is properly synced and truncatedPRAGMA journal_mode = WALin try-catch with automatic fallback toDELETEmode if WAL initialization failsRoot Cause
When the app crashes or is killed while WAL mode is active, the WAL file can be left in an inconsistent state. On next startup,
PRAGMA journal_mode = WALwould crash instead of handling the corrupted state gracefully.Testing
bun typecheckpassesCloses anomalyco#24287