Repository navigation
Conversation
jessevz
marked this pull request as draft
October 16, 2026 07:32
jessevz
marked this pull request as ready for review
October 20, 2026 06:48
There was a problem hiding this comment.
🟡 Changes recommended
Cache-path interpolation permits shell expansion, and the documented minimum supported build contradicts the implementation.
2 open issues
What changed in this PR
Adds configurable hashcat caching so agents can retain wordlist and kernel caches across cracker updates.
Changes:
- Adds CLI configuration and startup directory creation.
- Passes cache arguments to supported hashcat versions.
- Consolidates version parsing and adds tests and documentation.
| File | Description |
|---|---|
| tests/test_cache_path.py | Tests version gates, cache arguments, and output formats. |
| README.md | Documents cache configuration and usage. |
| htpclient/initialize.py | Creates the configured cache directory. |
| htpclient/hashcat_cracker.py | Integrates cache arguments and shared version parsing. |
| changelog.md | Records the cache-path feature. |
| main.py | Adds CLI parsing and absolute-path normalization. |
Review effort: Balanced
Comment on lines
+121
to
+123
| * The option is only passed to crackers new enough for it. It appears in hashcat at build | ||
| `7.1.2-627-g6570a49f2`, so the agent passes it to that build and later, and to any release after | ||
| 7.1.2. Anything older, including the 7.1.2 release itself, stays silent and is unaffected. |
| if not isdir(cache_path): | ||
| logging.debug(f"Ignoring cache-path '{cache_path}': not a directory, hashcat will use its own cache location") | ||
| return [] | ||
| return [f'{CACHE_PATH_FLAG}="{cache_path}"'] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for the hashcat cache path