Codecov Report

Merging #977 (18726a2) into develop (291af86) will increase coverage by 0.16%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #977      +/-   ##
===========================================
+ Coverage    70.12%   70.28%   +0.16%     
===========================================
  Files           76       76              
  Lines         7381     7398      +17     
===========================================
+ Hits          5176     5200      +24     
+ Misses        2205     2198       -7     

Hey @danielhrisca what problem does this PR try to solve? I don't quite get it. Was the value just not wrapped into a c_uint? Was it tested on real hardware? If yes, IMHO this can be merged.

@felixdivo i assume this solves #971

I think it was related to using the udsoncan package. I will check tomorrow

The ctypes documentation says

Python integers are passed as the platforms default C int type, their value is masked to fit into the C type.

So while using app_channel = ctypes.c_uint(app_channel) is technically correct it should not make a difference unless app_channel is greater than 2147483647 (2^31 - 1).
@danielhrisca did you see any difference with your version?

Can someone test this change locally?

@zariiii9003 Shall we merge this an close #971?

I would say we can merge this, but not close the issue you mentioned. I'm not sure if this fixes anything, but i'm very confident that it does not break anything.

Let's wait and see if someone else has similar problems once we release version 4.