Add a default fileno function to the BusABC#877
Merged
Conversation
… handle the exception raised if the bus doesn't override it.
zariiii9003
reviewed
Jul 31, 2020
Contributor
|
Looks good. I would like to make a followup change to slcan which will raise NotImplementedError on windows (which was the original motivation for this change). |
Codecov Report
@@ Coverage Diff @@
## develop #877 +/- ##
===========================================
+ Coverage 70.69% 70.71% +0.02%
===========================================
Files 71 71
Lines 6909 6915 +6
===========================================
+ Hits 4884 4890 +6
Misses 2025 2025 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modify Notifier to handle the exception raised if the bus doesn't override it.