capture OSErrors while receiving data - #87
Merged
Conversation
both sock.recv() and select.select(sock) throw errors when the device to which the socket is bound goes down. this patch should make the notifier thread survive such a condition (and bail out on the log) Closes: #86
Contributor
Author
|
btw, this code is slightly untested as it is a cleaned up version of what i actually used (the original hacked version would catch any i'm pretty confident that the code does work though, but have currently no possibility to actually test it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
both sock.recv() and select.select(sock) both throw errors when the device
to which the socket is bound goes down.
this patch should make the notifier thread survive such a condition
(and bail out on the log)
Closes: #86