Add TX/RX message direction to socketcan#780
Merged
Merged
Conversation
Contributor
Author
|
Don't judge me too much, please. :) My first try to submit something there. I actually got a pointer to implement that looking into candump tool and SocketCAN doc 4.1.7 section. Also, I am not sure if this change also needs to take into account |
Codecov Report
@@ Coverage Diff @@
## develop #780 +/- ##
==========================================
+ Coverage 69.48% 69.5% +0.02%
==========================================
Files 70 70
Lines 6557 6556 -1
==========================================
+ Hits 4556 4557 +1
+ Misses 2001 1999 -2 |
bessman
reviewed
Feb 27, 2020
bessman
reviewed
Feb 27, 2020
17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References #773 and #776