Skip to content

Fixed Slcan fileno raising an exception on windows #760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bmeisels wants to merge 2 commits into from
Closed

Fixed Slcan fileno raising an exception on windows #760

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d87cad7
Fixed Slcan fileno raising an exception on windows
bmeisels Jan 28, 2020
9840bdc
Merge branch 'develop' into slcan_fileno_fix
hardbyte Jul 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions can/interfaces/slcan.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,14 @@

"""

import io
from typing import Any, Optional, Tuple
from can import typechecking

import time
import logging

from can import BusABC, Message
from can import typechecking

logger = logging.getLogger(__name__)

Expand Down Expand Up @@ -252,9 +253,12 @@ def shutdown(self) -> None:
self.serialPortOrig.close()

def fileno(self) -> int:
if hasattr(self.serialPortOrig, "fileno"):
try:
return self.serialPortOrig.fileno()
# Return an invalid file descriptor on Windows
except (io.UnsupportedOperation):
# Return an invalid file descriptor on a platform which doesn't implement fileno such as Windows
pass

return -1

def get_version(
Expand Down