Fix date format to show correct day of month#754
Merged
Conversation
%m is month as a zero-padded decimal number %d is day of the month as a zero-padded decimal number
Codecov Report
@@ Coverage Diff @@
## develop #754 +/- ##
========================================
Coverage 69.52% 69.52%
========================================
Files 70 70
Lines 6485 6485
========================================
Hits 4509 4509
Misses 1976 1976 |
Contributor
Author
|
For reference, CANalyzer writes today's date in .asc-files thus: |
christiansandberg
approved these changes
Jan 7, 2020
Collaborator
christiansandberg
left a comment
There was a problem hiding this comment.
That seems reasonable. Don’t know why I got it wrong in the first place and why nobody noticed it before...
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ASCWriter currently writes the month twice (once as three-letter abbreviation and once as zero-padded decimal number), but does not write the day of month. I don't think this is correct. For example, today's date (2020-01-07) is currently written Tue Jan 01 01:14:48.625694 PM 2020.
With this fix, today's date will instead be written Tue Jan 07 01:14:48.625694 PM 2020.