Add support for VN8900 xlGetChannelTime function#733
Merged
Conversation
| try: | ||
| xldriver.xlGetSyncTime(self.port_handle, offset) | ||
| except: | ||
| xldriver.xlGetChannelTime(self.port_handle, self.mask, offset) |
Collaborator
There was a problem hiding this comment.
You could another level of try except so if both fails we can set self._time_offset = 0 since it is not required to have absolute timestamps.
Codecov Report
@@ Coverage Diff @@
## develop #733 +/- ##
===========================================
- Coverage 68.57% 68.52% -0.05%
===========================================
Files 69 69
Lines 6227 6234 +7
===========================================
+ Hits 4270 4272 +2
- Misses 1957 1962 +5 |
christiansandberg
approved these changes
Dec 2, 2019
Collaborator
christiansandberg
left a comment
There was a problem hiding this comment.
Thanks! Just run black on xldriver.py to format it.
Contributor
Author
|
I think it's ready |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #732