Added keycheck for windows platform - #724
Merged
Merged
Conversation
PCANBasic will log an error when the PEAK-Driver key could not be found.
Codecov Report
@@ Coverage Diff @@
## develop #724 +/- ##
===========================================
+ Coverage 68.32% 69.58% +1.25%
===========================================
Files 69 70 +1
Lines 6235 6493 +258
===========================================
+ Hits 4260 4518 +258
Misses 1975 1975 |
hardbyte
approved these changes
Jan 7, 2020
hardbyte
left a comment
Owner
There was a problem hiding this comment.
If this is required for using the driver it seems reasonable, if the driver allows any other method of providing the key perhaps we could support it.
Contributor
Author
|
Yes, I had problems when running my program on Windows PC's when the driver wasn't installed. This check lets me finish the program in exception when not present. |
felixdivo
reviewed
Jan 29, 2020
felixdivo
approved these changes
Jan 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PCANBasic will log an error when the PEAK-Driver key could not be found.
I figured this was the best place to add the check, so you don't need to keep a function on a more higher level.