Skip to content

Fully initialize usb2can Bus interface object. #501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hardbyte merged 3 commits into from
Feb 13, 2019
Merged

Fully initialize usb2can Bus interface object. #501

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
65bbc72
Fully initialize usb2can Bus interface object.
acolomb Feb 11, 2019
b050122
Add a note about the 32-bit only CANAL DLL.
acolomb Feb 11, 2019
1f2b9e1
Merge branch 'develop' into usb2can-constructor-fix
felixdivo Feb 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fully initialize usb2can Bus interface object. 
The usb2can interface backend currently does not work because the
_filters member is not initialized in the constructor of
can.interfaces.usb2can.Usb2canBus.  Call the parent class constructor
to pull in the missing object attributes.
  • Loading branch information
@acolomb
acolomb committed Feb 11, 2019
commit 65bbc722835aa795921a7fe1793d829ec34c6ac3
2 changes: 2 additions & 0 deletions can/interfaces/usb2can/usb2canInterface.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,8 @@ def __init__(self, channel, *args, **kwargs):

self.handle = self.can.open(connector.encode('utf-8'), enable_flags)

super(Usb2canBus, self).__init__(channel=channel, *args, **kwargs)

def send(self, msg, timeout=None):
tx = message_convert_tx(msg)
if timeout:
Expand Down