Remove shebangs from files in the module#429
Merged
hardbyte merged 2 commits intohardbyte:developfrom Sep 27, 2018
cottsay:shebangs
Merged
Remove shebangs from files in the module#429hardbyte merged 2 commits intohardbyte:developfrom cottsay:shebangs
hardbyte merged 2 commits intohardbyte:developfrom
cottsay:shebangs
Conversation
The execution bit is removed from these files when they are installed, rendering the shebangs useless. In most cases, the scripts don't handle `__main__` anyway, which makes the shebang misleading as well.
Codecov Report
@@ Coverage Diff @@
## develop #429 +/- ##
========================================
Coverage 62.29% 62.29%
========================================
Files 55 55
Lines 4612 4612
========================================
Hits 2873 2873
Misses 1739 1739 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The execution bit is removed from these files when they are installed, rendering the shebangs useless. In most cases, the scripts don't handle
__main__anyway, which makes the shebang misleading as well.This should wrap up the discussion in #418.