IsOpen should not be use to check if bus is open#381
Merged
Conversation
felixdivo
reviewed
Aug 1, 2018
Collaborator
felixdivo
left a comment
There was a problem hiding this comment.
You could leave a brief comment on why this was changed in the code.
Collaborator
|
I see. Sorry, I wanted to write this: You could leave a brief comment in the code on why this was changed. |
Collaborator
Author
|
@felixdivo, I am not sure the source code it the best place to document the change history. |
Collaborator
|
Okay. |
Codecov Report
@@ Coverage Diff @@
## develop #381 +/- ##
========================================
Coverage 59.31% 59.31%
========================================
Files 55 55
Lines 4242 4242
========================================
Hits 2516 2516
Misses 1726 1726 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IsOpenis the handle returned fromicsneoOpenDevice()API and not a flag saying if the device is open or not.