Skip to content

Add coverage report generation #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
felixdivo merged 10 commits into from
Jul 1, 2018
Merged

Add coverage report generation #346

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
d5cce3d
added coverage plugin for pytest and added it to travis CI
felixdivo Jun 29, 2018
53b4c2e
getting pytest cov to work
felixdivo Jun 29, 2018
9147083
cleanups and coverage reports for AppVeyor
felixdivo Jun 29, 2018
ce928a7
added extras to test requirment in setup.py
felixdivo Jun 29, 2018
0ca3755
for loop fix
felixdivo Jun 29, 2018
9621a29
catch exception in ICS find devices
felixdivo Jun 29, 2018
65b5eb3
finer grained dependencies
felixdivo Jun 29, 2018
36361d1
Add codecov to travis
hardbyte Jun 30, 2018
cdcb612
Add codecov to appveyor
hardbyte Jun 30, 2018
cc12faf
fix requested changes
felixdivo Jul 1, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
catch exception in ICS find devices
  • Loading branch information
@felixdivo
felixdivo committed Jun 29, 2018
commit 9621a29e4ea80b97412d730970099d4ad84785b0
10 changes: 7 additions & 3 deletions can/interfaces/ics_neovi/neovi_bus.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,9 +149,13 @@ def _detect_available_configs():
if ics is None:
return []
# TODO: add the channel(s)
return [{
'serial': NeoViBus.get_serial_number(device)
} for device in ics.find_devices()]
try:
return [{
'serial': NeoViBus.get_serial_number(device)
} for device in ics.find_devices()]
except Exception as e:
Copy link
Copy Markdown
Owner

@hardbyte hardbyte Jun 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this try/for should be inverted - if the try was around each call to get_serial_number then any working devices can be returned?

Copy link
Copy Markdown
Collaborator Author

@felixdivo felixdivo Jul 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made the code a bit clearer to show that only the call to ics.find_devices() is wrapped in a try-catch clause. The method NeoViBus.get_serial_number() itself should never fail.

logger.debug("Failed to detect configs: %s", e)
return []

def _find_device(self, type_filter=None, serial=None):
if type_filter is not None:
Expand Down