Skip to content

can.Notifier enhancements #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
felixdivo merged 8 commits into from
Mar 16, 2018
Merged

can.Notifier enhancements #266

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e5165c3
prepended an underscore to private fields/methdos of can.Notifier
felixdivo Feb 23, 2018
99f3fdc
added add_listener and remove_listener to can.Notifier. closes #265
felixdivo Feb 23, 2018
5e361a3
added tests for can.Notifier.add_listener() and remove_listener()
felixdivo Feb 27, 2018
a10250d
Merge branch 'develop' into notifier-enhancements
felixdivo Feb 27, 2018
4c4c972
fix an import problem that was cuased by pervious merge
felixdivo Feb 27, 2018
fbb8b03
attempt fixing Sqlite tests
felixdivo Feb 28, 2018
0fd12a7
added tests for can.Notifier.add_listener() and remove_listener()
felixdivo Feb 27, 2018
cce664a
Merge branch 'develop' into notifier-enhancements
felixdivo Mar 16, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
attempt fixing Sqlite tests
  • Loading branch information
@felixdivo
felixdivo committed Feb 28, 2018
commit fbb8b032431d1b1cbbf273cfdcee897cf6fc91ac
2 changes: 1 addition & 1 deletion test/logformats_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ class TestSqliteDatabaseFormat(unittest.TestCase):

def test_writer_and_reader(self):
_test_writer_and_reader(self, can.SqliteWriter, can.SqliteReader,
sleep_time=can.SqliteWriter.MAX_TIME_BETWEEN_WRITES,
sleep_time=can.SqliteWriter.MAX_TIME_BETWEEN_WRITES + 0.5,
check_comments=False)

def testSQLWriterWritesToSameFile(self):
Expand Down