Skip to content

Implement _detect_available_configs for Seeedbus #1690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RyanHope wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Implement _detect_available_configs for Seeedbus #1690

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
35075fb
implement _detect_available_configs for SeeedBus
RyanHope Nov 14, 2023
97db60a
Format code with black
RyanHope Nov 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Format code with black
  • Loading branch information
@RyanHope
RyanHope committed Nov 14, 2023
commit 97db60a730f12d9c7a83a9ff16c8a5737e2ddae4
6 changes: 2 additions & 4 deletions can/interfaces/seeedstudio/seeedstudio.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,7 +325,5 @@ def _detect_available_configs() -> List[AutoDetectedConfig]:
configs = []
for port in list_comports():
if port.vid == 0x1A86 and port.pid == 0x7523:
configs.append(
{"interface": "seeedstudio", "channel": port.device}
)
return configs
configs.append({"interface": "seeedstudio", "channel": port.device})
return configs
Copy link
Copy Markdown
Collaborator

@zariiii9003 zariiii9003 Nov 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return configs
return configs # type: ignore[return-value]