Skip to content

Implement receive_own_messages option for more buses#166

Merged
christiansandberg merged 5 commits into
hardbyte:developfrom
christiansandberg:160-kvaser-reads-own-messages
Jun 21, 2017
Merged

Implement receive_own_messages option for more buses#166
christiansandberg merged 5 commits into
hardbyte:developfrom
christiansandberg:160-kvaser-reads-own-messages

Conversation

@christiansandberg

Copy link
Copy Markdown
Collaborator

Fixes #160.

Also make logger and player use single_handle.
Fixes hardbyte#160.
@christiansandberg

Copy link
Copy Markdown
Collaborator Author

I changed the solution and scope a bit. I saw that socketcan_ctypes had receive_own_messages as an option so I used that in kvaser, socketcan_native and virtual buses as well.

@christiansandberg christiansandberg changed the title Don't use local echo for Kvaser by default Implement receive_own_messages option for more buses Jun 20, 2017

@hardbyte hardbyte left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers - looks good to me.

@christiansandberg christiansandberg merged commit b22aed7 into hardbyte:develop Jun 21, 2017
@christiansandberg christiansandberg deleted the 160-kvaser-reads-own-messages branch June 21, 2017 17:35
boris-wenzlaff pushed a commit to boris-wenzlaff/python-can that referenced this pull request Mar 23, 2018
Don't use local echo for Kvaser by default unless single_handle is used (fixes hardbyte#160)
Make logger and player use single_handle.
Add receive_own_messages to socketcan_native, virtual and kvaser buses.
Fix filtering of extended and standard IDs for socketcan.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants