Add __del__ method to BusABC#1489
Merged
Merged
Conversation
Tbruno25
commented
Jan 17, 2023
43d6418 to
7f028d6
Compare
felixdivo
reviewed
Jan 22, 2023
felixdivo
reviewed
Jan 22, 2023
58b0d28 to
3aaaf4c
Compare
Co-authored-by: Felix Divo <4403130+felixdivo@users.noreply.github.com>
Co-authored-by: Felix Divo <4403130+felixdivo@users.noreply.github.com>
3aaaf4c to
b694ef7
Compare
b694ef7 to
a779b91
Compare
6e87c68 to
248d64c
Compare
felixdivo
reviewed
Jan 24, 2023
Collaborator
|
I added the |
Co-authored-by: Felix Divo <4403130+felixdivo@users.noreply.github.com>
3ebcc14 to
e3f2f6e
Compare
felixdivo
approved these changes
Jan 30, 2023
Collaborator
felixdivo
left a comment
There was a problem hiding this comment.
This is great! I'll have to check if pytest.mark.filterwarnings is really a good idea, and not hiding any other problems. Else, this can be merged.
Collaborator
Collaborator
|
@felixdivo i cherry-picked your changes and fixed the AttributeError. Would you like to take another look? |
felixdivo
approved these changes
Mar 30, 2023
Collaborator
felixdivo
left a comment
There was a problem hiding this comment.
I think this looks good. Didn't test it locally, but you probably did and we have good unit tests on this. Nice work! 🥳
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial PR to address #1448
Closes #1448