Skip to content

Update BufferedReader.get_message docstring#1397

Merged
zariiii9003 merged 1 commit into
hardbyte:developfrom
barbacbd:update_get_message_docstring
Oct 3, 2022
Merged

Update BufferedReader.get_message docstring#1397
zariiii9003 merged 1 commit into
hardbyte:developfrom
barbacbd:update_get_message_docstring

Conversation

@barbacbd
Copy link
Copy Markdown
Contributor

** Docstring now states that the get_message method utilizes a FIFO ordering for grabbing messages from the queue.

#1207

Copy link
Copy Markdown
Contributor

@nertpinx nertpinx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would just change the one mentioned thing, otherwise it looks fine to me.

Comment thread can/listener.py Outdated
@barbacbd barbacbd force-pushed the update_get_message_docstring branch from 56a39fa to fca97b0 Compare September 21, 2022 11:52
@barbacbd barbacbd requested a review from nertpinx September 21, 2022 11:52
Comment thread can/listener.py Outdated
Comment thread can/listener.py Outdated
** Docstring now states that the `get_message` method utilizes a FIFO
ordering for grabbing messages from the queue.
@barbacbd barbacbd force-pushed the update_get_message_docstring branch from 34f68ea to ed6bf9f Compare October 3, 2022 11:37
@barbacbd barbacbd requested review from zariiii9003 and removed request for nertpinx October 3, 2022 11:37
Copy link
Copy Markdown
Collaborator

@zariiii9003 zariiii9003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@zariiii9003 zariiii9003 merged commit 23b6b19 into hardbyte:develop Oct 3, 2022
j-c-cook added a commit to j-c-cook/python-can that referenced this pull request Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants