Vector init refactor#1389
Merged
Merged
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #1389 +/- ##
===========================================
+ Coverage 66.19% 66.23% +0.04%
===========================================
Files 86 86
Lines 9039 9060 +21
===========================================
+ Hits 5983 6001 +18
- Misses 3056 3059 +3 |
j-c-cook
added a commit
to j-c-cook/python-can
that referenced
this pull request
Nov 11, 2022
This reverts commit 1e11f21.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1388
Refactor
VectorBus.__init__()and extract methodsVectorBus._find_global_channel_idx(),VectorBus._set_bitrate_canfd()andVectorBus._set_bitrate_can().