socketcan: Make find_available_interfaces() find slcanX interfaces#1369
Merged
zariiii9003 merged 4 commits intoSep 3, 2022
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #1369 +/- ##
========================================
Coverage 66.25% 66.25%
========================================
Files 86 86
Lines 9021 9021
========================================
Hits 5977 5977
Misses 3044 3044 |
hartkopp
reviewed
Aug 11, 2022
Contributor
Author
|
@hartkopp @zariiii9003 Thanks, |
Collaborator
Looks good to me! |
j-c-cook
added a commit
to j-c-cook/python-can
that referenced
this pull request
Nov 11, 2022
…faces (hardbyte#1369)" This reverts commit ad8b948.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
This change allows
can.detect_available_configs(['socketcan'])find not justcanXandvcanXinterfaces, but alsoslcanXinterfaces too. Such names are given by default to interfaces that are created using theslcandutility.The module has an option to work with SLCAN adapters directly, but creating a SocketCAN interface instead can be beneficial too (e.g.: make it possible to use Wireshark, can-utils, cantools and etc.). For this reason I added few lines to the doc about how to use SLCAN adapters with socketcan.
Regards,
Maksim