add missing vector devices#1296
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1296 +/- ##
===========================================
- Coverage 66.06% 66.03% -0.04%
===========================================
Files 86 86
Lines 8915 8917 +2
===========================================
- Hits 5890 5888 -2
- Misses 3025 3029 +4 |
zariiii9003
approved these changes
Apr 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During the 4.0.0 release, you now check the int returned by vxlapi against a local enum. The local enum is out of date.
I would strongly recommend to change this logic since it results in you having to update the code every time vector releases a new device and thus extends this enum for their vxlapi.
In the meantime, please consider releasing this as a hotfix.