ASCReader bugfix#1257
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1257 +/- ##
===========================================
+ Coverage 65.92% 65.99% +0.06%
===========================================
Files 86 86
Lines 8889 8901 +12
===========================================
+ Hits 5860 5874 +14
+ Misses 3029 3027 -2 |
felixdivo
approved these changes
Feb 9, 2022
Collaborator
felixdivo
left a comment
There was a problem hiding this comment.
Oh wow, this is surprisingly large. Looks good to me!
Collaborator
Author
Yeah, i tested a few more files and noticed that the date conversion failed almost every time. To be honest i don't like the ASCReader implementation that much. This C++ ASC implementation seems much more elegant. We still have some room for improvement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ASCReader.start_time was never set, when no trigger block was present.
Closes #1256