Skip to content

[IO][ASC]: fix data length#1246

Merged
felixdivo merged 1 commit into
hardbyte:developfrom
jazi007:io-asc-dlc-fix
Feb 11, 2022
Merged

[IO][ASC]: fix data length#1246
felixdivo merged 1 commit into
hardbyte:developfrom
jazi007:io-asc-dlc-fix

Conversation

@jazi007
Copy link
Copy Markdown
Contributor

@jazi007 jazi007 commented Jan 29, 2022

Fix #1245

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 1, 2022

Codecov Report

Merging #1246 (36a7096) into develop (24ea2f2) will increase coverage by 0.00%.
The diff coverage is 85.71%.

@@           Coverage Diff            @@
##           develop    #1246   +/-   ##
========================================
  Coverage    65.89%   65.89%           
========================================
  Files           86       86           
  Lines         8887     8891    +4     
========================================
+ Hits          5856     5859    +3     
- Misses        3031     3032    +1     

Comment thread can/io/asc.py
Copy link
Copy Markdown
Collaborator

@felixdivo felixdivo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall! Thanks for the analysis!

@felixdivo felixdivo added bug file-io about reading & writing to files labels Feb 6, 2022
@felixdivo felixdivo added this to the 4.0.0 Release milestone Feb 6, 2022
@felixdivo felixdivo requested a review from pierreluctg February 9, 2022 10:19
@felixdivo felixdivo merged commit f1a012c into hardbyte:develop Feb 11, 2022
@jazi007 jazi007 deleted the io-asc-dlc-fix branch September 19, 2023 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug file-io about reading & writing to files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[io][asc]: parser / writer using DLC as data length

2 participants