Move Static Code Analysis to Github Actions#1224
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1224 +/- ##
===========================================
+ Coverage 65.83% 65.87% +0.03%
===========================================
Files 86 86
Lines 8860 8872 +12
===========================================
+ Hits 5833 5844 +11
- Misses 3027 3028 +1 |
felixdivo
approved these changes
Jan 20, 2022
Collaborator
felixdivo
left a comment
There was a problem hiding this comment.
Cool! Great cleanups :)
| pip install -r requirements-lint.txt | ||
| - name: mypy 3.7 | ||
| run: | | ||
| mypy --python-version 3.7 . |
Collaborator
There was a problem hiding this comment.
Nice to test all of the version!
This was referenced Jan 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move mypy and pylint to github.
See #1219.
There's still some issues with GzipASCWriter and mypy that i won't fix because of #1221