Skip to content

Update Mergify rules - #1146

Merged
felixdivo merged 3 commits into
developfrom
fix-mergify-config
Oct 26, 2021
Merged

Update Mergify rules#1146
felixdivo merged 3 commits into
developfrom
fix-mergify-config

Conversation

@felixdivo

Copy link
Copy Markdown
Collaborator

This change was required due to the deprection of our current setup. It was shown in the mergify results tab on our PRs and would cause the Mergify setup to fail from December on. I hope that I nowconfigured everything correctly.

This change was required due to the deprection of our current setup (https://blog.mergify.io/strict-mode-deprecation/). It was shown in the mergify results tab on our PRs and would cause the Mergify setup to fail from December on. I hope that I nowconfigured everything correctly.
@felixdivo felixdivo added blocker QA about improving and maintaining the quality of the library labels Oct 25, 2021
@felixdivo felixdivo added this to the 4.0.0 Release milestone Oct 25, 2021
@felixdivo
felixdivo requested a review from hardbyte October 25, 2021 20:46
@felixdivo felixdivo self-assigned this Oct 25, 2021
@codecov

codecov Bot commented Oct 25, 2021

Copy link
Copy Markdown

Codecov Report

Merging #1146 (f2860f6) into develop (d4aefcf) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #1146   +/-   ##
========================================
  Coverage    70.49%   70.49%           
========================================
  Files           79       79           
  Lines         7681     7681           
========================================
  Hits          5415     5415           
  Misses        2266     2266           

@felixdivo

Copy link
Copy Markdown
Collaborator Author

@Mergifyio rebase

@mergify

mergify Bot commented Oct 25, 2021

Copy link
Copy Markdown
Contributor

rebase

☑️ Nothing to do

Details
  • -closed [:pushpin: rebase requirement]
  • #commits-behind>0 [:pushpin: rebase requirement]

@felixdivo

Copy link
Copy Markdown
Collaborator Author

@Mergifyio rebase

@mergify

mergify Bot commented Oct 26, 2021

Copy link
Copy Markdown
Contributor

rebase

☑️ Nothing to do

Details
  • -closed [:pushpin: rebase requirement]
  • #commits-behind>0 [:pushpin: rebase requirement]

@felixdivo

Copy link
Copy Markdown
Collaborator Author

I also changed Mergify to look for Github Actions instead of Travis, to match what we use now.

@felixdivo

Copy link
Copy Markdown
Collaborator Author

Configuration changed. This pull request must be merged manually

@felixdivo
felixdivo merged commit 784b871 into develop Oct 26, 2021
@felixdivo
felixdivo deleted the fix-mergify-config branch October 26, 2021 06:57
cowo78 pushed a commit to cowo78/python-can that referenced this pull request Dec 9, 2021
* Update Mergify rules

This change was required due to the deprection of our current setup (https://blog.mergify.io/strict-mode-deprecation/). It was shown in the mergify results tab on our PRs and would cause the Mergify setup to fail from December on. I hope that I nowconfigured everything correctly.

* Fix mergify to use Github Actions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blocker QA about improving and maintaining the quality of the library

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants