Skip to content

Supress exception occuring in NIXNET _detect_available_configs() - #1085

Merged
felixdivo merged 10 commits into
developfrom
felixdivo-fix-nixnet-detect_available_configs
Jun 24, 2021
Merged

Supress exception occuring in NIXNET _detect_available_configs()#1085
felixdivo merged 10 commits into
developfrom
felixdivo-fix-nixnet-detect_available_configs

Conversation

@felixdivo

Copy link
Copy Markdown
Collaborator

Similar to #1077: If the python nixnet package is installed but not the DLL, the following error would be thrown:

nixnet._lib.XnetNotFoundError:
Could not find an installation of NI-XNET.
Please ensure that NI-XNET is installed on this machine or contact National Instruments for support.

Also uses a context manager for more safety.

@felixdivo felixdivo added the bug label Jun 9, 2021
@felixdivo felixdivo added this to the 4.0.0 Release milestone Jun 9, 2021
@felixdivo felixdivo self-assigned this Jun 9, 2021
@mergify
mergify Bot requested a review from hardbyte June 9, 2021 09:16
@codecov

codecov Bot commented Jun 9, 2021

Copy link
Copy Markdown

Codecov Report

Merging #1085 (74b4176) into develop (0262b8d) will decrease coverage by 0.07%.
The diff coverage is 11.11%.

@@             Coverage Diff             @@
##           develop    #1085      +/-   ##
===========================================
- Coverage    70.64%   70.56%   -0.08%     
===========================================
  Files           79       79              
  Lines         7655     7658       +3     
===========================================
- Hits          5408     5404       -4     
- Misses        2247     2254       +7     

@felixdivo
felixdivo merged commit c64f162 into develop Jun 24, 2021
@mergify
mergify Bot deleted the felixdivo-fix-nixnet-detect_available_configs branch June 24, 2021 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants