Skip to content

Test on 3.10.0-beta.2 - #1069

Merged
hardbyte merged 6 commits into
hardbyte:developfrom
zariiii9003:update_3_10
Jul 14, 2021
Merged

Test on 3.10.0-beta.2#1069
hardbyte merged 6 commits into
hardbyte:developfrom
zariiii9003:update_3_10

Conversation

@zariiii9003

@zariiii9003 zariiii9003 commented Jun 5, 2021

Copy link
Copy Markdown
Collaborator

Pytest update was necessary due to pytest-dev/pytest#8540

Trace 

GLOB sdist-make: /home/runner/work/python-can/python-can/setup.py
gh create: /home/runner/work/python-can/python-can/.tox/gh
gh installdeps: pytest~=5.3, pytest-timeout~=1.3, pytest-cov~=2.8, coverage==4.5.*, codecov==2.1.10, hypothesis~=4.56, pyserial~=3.0
gh inst: /home/runner/work/python-can/python-can/.tox/.tmp/package/1/python-can-4.0.0.dev2.zip
gh installed: attrs==21.2.0,certifi==2021.5.30,chardet==4.0.0,codecov==2.1.10,coverage==4.5.4,hypothesis==4.57.1,idna==2.10,more-itertools==8.8.0,msgpack==1.0.2,mypy-extensions==0.4.3,packaging==20.9,pluggy==0.13.1,py==1.10.0,pyparsing==2.4.7,pyserial==3.5,pytest==5.4.3,pytest-cov==2.10.1,pytest-timeout==1.4.2,python-can @ file:///home/runner/work/python-can/python-can/.tox/.tmp/package/1/python-can-4.0.0.dev2.zip,requests==2.25.1,sortedcontainers==2.4.0,urllib3==1.26.5,wcwidth==0.2.5,wrapt==1.12.1
gh run-test-pre: PYTHONHASHSEED='4019826288'
gh run-test: commands[0] | pytest
Traceback (most recent call last):
  File "/home/runner/work/python-can/python-can/.tox/gh/bin/pytest", line 8, in <module>
    sys.exit(main())
  File "/home/runner/work/python-can/python-can/.tox/gh/lib/python3.10/site-packages/_pytest/config/__init__.py", line 105, in main
    config = _prepareconfig(args, plugins)
  File "/home/runner/work/python-can/python-can/.tox/gh/lib/python3.10/site-packages/_pytest/config/__init__.py", line 257, in _prepareconfig
    return pluginmanager.hook.pytest_cmdline_parse(
  File "/home/runner/work/python-can/python-can/.tox/gh/lib/python3.10/site-packages/pluggy/hooks.py", line 286, in __call__
    return self._hookexec(self, self.get_hookimpls(), kwargs)
  File "/home/runner/work/python-can/python-can/.tox/gh/lib/python3.10/site-packages/pluggy/manager.py", line 93, in _hookexec
    return self._inner_hookexec(hook, methods, kwargs)
  File "/home/runner/work/python-can/python-can/.tox/gh/lib/python3.10/site-packages/pluggy/manager.py", line 84, in <lambda>
    self._inner_hookexec = lambda hook, methods, kwargs: hook.multicall(
  File "/home/runner/work/python-can/python-can/.tox/gh/lib/python3.10/site-packages/pluggy/callers.py", line 203, in _multicall
    gen.send(outcome)
  File "/home/runner/work/python-can/python-can/.tox/gh/lib/python3.10/site-packages/_pytest/helpconfig.py", line 90, in pytest_cmdline_parse
    config = outcome.get_result()
  File "/home/runner/work/python-can/python-can/.tox/gh/lib/python3.10/site-packages/pluggy/callers.py", line 80, in get_result
    raise ex[1].with_traceback(ex[2])
  File "/home/runner/work/python-can/python-can/.tox/gh/lib/python3.10/site-packages/pluggy/callers.py", line 187, in _multicall
    res = hook_impl.function(*args)
  File "/home/runner/work/python-can/python-can/.tox/gh/lib/python3.10/site-packages/_pytest/config/__init__.py", line 836, in pytest_cmdline_parse
    self.parse(args)
  File "/home/runner/work/python-can/python-can/.tox/gh/lib/python3.10/site-packages/_pytest/config/__init__.py", line 1044, in parse
    self._preparse(args, addopts=addopts)
  File "/home/runner/work/python-can/python-can/.tox/gh/lib/python3.10/site-packages/_pytest/config/__init__.py", line 992, in _preparse
    self.pluginmanager.load_setuptools_entrypoints("pytest11")
  File "/home/runner/work/python-can/python-can/.tox/gh/lib/python3.10/site-packages/pluggy/manager.py", line 299, in load_setuptools_entrypoints
    plugin = ep.load()
  File "/opt/hostedtoolcache/Python/3.10.0-beta.2/x64/lib/python3.10/importlib/metadata/__init__.py", line 162, in load
    module = import_module(match.group('module'))
  File "/opt/hostedtoolcache/Python/3.10.0-beta.2/x64/lib/python3.10/importlib/__init__.py", line 126, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1050, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1027, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1006, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 688, in _load_unlocked
  File "/home/runner/work/python-can/python-can/.tox/gh/lib/python3.10/site-packages/_pytest/assertion/rewrite.py", line 143, in exec_module
    source_stat, co = _rewrite_test(fn, self.config)
  File "/home/runner/work/python-can/python-can/.tox/gh/lib/python3.10/site-packages/_pytest/assertion/rewrite.py", line 330, in _rewrite_test
    co = compile(tree, fn, "exec", dont_inherit=True)
TypeError: required field "lineno" missing from alias
ERROR: InvocationError for command /home/runner/work/python-can/python-can/.tox/gh/bin/pytest (exited with code 1)

@mergify
mergify Bot requested a review from hardbyte June 5, 2021 23:05
@codecov

codecov Bot commented Jun 5, 2021 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #1069 (f67b4e4) into develop (8e6f05a) will decrease coverage by 0.23%.
The diff coverage is n/a.

❗ Current head f67b4e4 differs from pull request most recent head cc8d115. Consider uploading reports for the commit cc8d115 to get more accurate results

@@             Coverage Diff             @@
##           develop    #1069      +/-   ##
===========================================
- Coverage    70.71%   70.48%   -0.24%     
===========================================
  Files           79       79              
  Lines         7616     7616              
===========================================
- Hits          5386     5368      -18     
- Misses        2230     2248      +18

@felixdivo felixdivo added this to the 4.0.0 Release milestone Jun 6, 2021
@zariiii9003

zariiii9003 commented Jun 6, 2021

Copy link
Copy Markdown
Collaborator Author

@Mergifyio rebase

@mergify

mergify Bot commented Jun 6, 2021

Copy link
Copy Markdown
Contributor

Command rebase: failure

Pull request can't be updated with latest base branch changes
GitHub App like Mergify are not allowed to rebase pull request where .github/workflows is changed.
This pull request must be rebased manually.
err-code: 0F816

@zariiii9003

zariiii9003 commented Jun 6, 2021

Copy link
Copy Markdown
Collaborator Author

I tried to fix the codecov issues by using the codecov action, but maybe the problems are not even caused by my changes: codecov/codecov-action#330

@felixdivo

felixdivo commented Jun 7, 2021

Copy link
Copy Markdown
Collaborator

This would also remove coverage collection when testing on Travis (which is only relevant for Socketcan).

@zariiii9003

zariiii9003 commented Jun 7, 2021

Copy link
Copy Markdown
Collaborator Author

This would also remove coverage collection when testing on Travis (which is only relevant for Socketcan).

I don't think so. For travis it is still called via tox file.

@hardbyte the replies on stackoverflow suggest that rotating the codecov token might help. Could you try?

@felixdivo

felixdivo commented Jun 7, 2021

Copy link
Copy Markdown
Collaborator

For travis it is still called via tox file.

Yes and No. If I understand it correctly, that is removed from the tox file here.

@zariiii9003

zariiii9003 commented Jun 7, 2021

Copy link
Copy Markdown
Collaborator Author

For travis it is still called via tox file.

Yes and No. If I understand it correctly, that is removed from the tox file here.

But only for the github environment. The command is still present for Travis

@felixdivo

felixdivo commented Jun 11, 2021

Copy link
Copy Markdown
Collaborator

The failures of Travis should be fixed on develop by now, so an update should get this CI to become green:

@Mergifyio update

@mergify

mergify Bot commented Jun 11, 2021

Copy link
Copy Markdown
Contributor

Command update: success

Branch has been successfully updated

@felixdivo felixdivo mentioned this pull request Jun 14, 2021
Merged
hardbyte
hardbyte approved these changes Jun 24, 2021
View reviewed changes

@hardbyte hardbyte left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay looking at this.

I assume the codecov token is fine as is?

felixdivo
felixdivo reviewed Jul 14, 2021
View reviewed changes
Comment thread .github/workflows/build.yml Outdated
@hardbyte @felixdivo
Update .github/workflows/build.yml
cc8d115 
Co-authored-by: Felix Divo <4403130+felixdivo@users.noreply.github.com>
@hardbyte
hardbyte merged commit 5b63bb2 into hardbyte:develop Jul 14, 2021
@zariiii9003
zariiii9003 deleted the update_3_10 branch January 16, 2022 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@felixdivo felixdivo felixdivo approved these changes
@hardbyte hardbyte hardbyte approved these changes

Assignees

@zariiii9003 zariiii9003

Labels

testing

Projects

None yet

Milestone

4.0.0 Release

Development

Successfully merging this pull request may close these issues.

3 participants

@zariiii9003 @felixdivo @hardbyte