Skip to content

vector interface: do not raise error for empty queue status#1054

Closed
jazi007 wants to merge 1 commit into
hardbyte:developfrom
jazi007:vector-error-fix
Closed

vector interface: do not raise error for empty queue status#1054
jazi007 wants to merge 1 commit into
hardbyte:developfrom
jazi007:vector-error-fix

Conversation

@jazi007
Copy link
Copy Markdown
Contributor

@jazi007 jazi007 commented May 19, 2021

No description provided.

@mergify mergify Bot requested a review from hardbyte May 19, 2021 12:50
@felixdivo felixdivo requested a review from zariiii9003 June 2, 2021 09:59
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 2, 2021

Codecov Report

Merging #1054 (04eaf1d) into develop (e79fd55) will decrease coverage by 6.30%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #1054      +/-   ##
===========================================
- Coverage    70.82%   64.52%   -6.31%     
===========================================
  Files           79       79              
  Lines         7610     7610              
===========================================
- Hits          5390     4910     -480     
- Misses        2220     2700     +480     

@zariiii9003
Copy link
Copy Markdown
Collaborator

This could possibly break client code that relies on these errors being raised. This is also unnecessary once #1052 is merged.
I will close this for now. You can reopen if you disagree.

@zariiii9003 zariiii9003 closed this Jun 3, 2021
@jazi007 jazi007 deleted the vector-error-fix branch June 4, 2021 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants