fix(api): reject unknown JSON fields in request bodies#405
Open
Minin1991 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, JSON request bodies containing unknown fields could be accepted by the Data Plane API and silently decoded into client-native models with unsupported fields dropped.
This made it possible for users or automation pipelines to believe that a submitted configuration parameter was applied, while the field was actually ignored during decoding.
Add a strict pre-decode validation step in the JSON consumer. The request body is first decoded into a generic JSON structure and checked against the target Go model using reflection. If an unknown field is found, the API now returns a parsing error instead of silently dropping the field.
The check supports nested structs, embedded model structs, maps such as backend servers, and arrays. Plain text raw configuration endpoints are excluded from this validation.
This helps GitOps/CI pipelines fail early when a request contains misspelled or unsupported configuration parameters.