Skip to content

DEV-1211: docs: add Fluent UI theme recipe#12292

Merged
qunabu merged 12 commits intodevelopfrom
feature/fluent-ui-handsontable-recipe-518e
Apr 17, 2026
Merged

DEV-1211: docs: add Fluent UI theme recipe#12292
qunabu merged 12 commits intodevelopfrom
feature/fluent-ui-handsontable-recipe-518e

Conversation

@qunabu
Copy link
Copy Markdown
Contributor

@qunabu qunabu commented Apr 8, 2026

Context

Adds a new Themes recipe that shows how to integrate Handsontable with a Fluent UI-based React app by registering a custom theme and mapping Fluent design tokens.

In response to review feedback, the embedded sandbox and recipe snippet were retuned to look closer to Fluent Table defaults:

  • Segoe UI font stack.
  • Fluent-like neutral text/background colors.
  • Header/background/border tuning.
  • Roomier cell and menu paddings.

How has this been tested?

  • npm run docs:lint --prefix docs
  • Verified CodeSandbox create API response returns sandbox id (zjtfff).
  • Verified sandbox URL resolves and renders in docs iframe:
    • https://codesandbox.io/s/zjtfff?view=preview
  • Manual docs walkthrough in browser:
    • Verified the recipe page renders in React docs.
    • Verified iframe no longer shows the SSE deprecation banner.
    • Verified embedded sandbox uses updated Fluent-style typography, colors, and spacing.

fluent_ui_recipe_docs_walkthrough.mp4
React sidebar with Fluent UI recipe
Updated Fluent sandbox preview

Types of changes

  • New feature or improvement (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Additional language file or change to the existing one (translations)

Related issue(s):

  1. DEV-1211

Affected project(s):

  • handsontable
  • @handsontable/angular-wrapper
  • @handsontable/react-wrapper
  • @handsontable/vue3

Checklist:

[skip changelog]

To show artifacts inline, enable in settings.

Open in Web Open in Cursor 

Co-authored-by: Mateusz Wojczal <qunabu@users.noreply.github.com>
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Apr 8, 2026

More templates

npm i https://pkg.pr.new/handsontable@12292
npm i https://pkg.pr.new/@handsontable/react-wrapper@12292
npm i https://pkg.pr.new/@handsontable/vue3@12292
npm i https://pkg.pr.new/@handsontable/angular-wrapper@12292

commit: a139795

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 8, 2026

Performance tests results

Artifacts: performance-tests-output (open the workflow run, then download performance-tests-output).


Metric latest current % change Value change
Total (ms) 15535 15192 -2.2% -343
System (ms) 580 541 -6.7% -39
Scripting (ms) 5188 3160 -39.1% -2028
Rendering (ms) 3156 2615 -17.1% -541
Loading (ms) 0 0 0% 0
Painting (ms) 591 533 -9.8% -58
Experience (ms)
Idle (ms) 6021 8342 +38.5% +2321
Min JS heap (kb) 924 kb 924 kb +0.0% 0
Max JS heap (Mb) 39.7 Mb 53.1 Mb +33.7% +13.4 Mb
Min Documents (count) 2 2 +0.0% 0
Max Documents (count) 4 4 +0.0% 0
Min Nodes (count) 20 20 +0.0% 0
Max Nodes (count) 150720 150779 +0.0% +59
Min Listeners (count) 0 0 0% 0
Max Listeners (count) 153 156 +2.0% +3

Co-authored-by: Mateusz Wojczal <qunabu@users.noreply.github.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 8, 2026

✅ Preview documentation is is available now
Current staging version of documentation is available at: https://dev-handsontable-feature-fluent-ui-ha.netlify.app/docs

Co-authored-by: Mateusz Wojczal <qunabu@users.noreply.github.com>
@qunabu qunabu changed the title docs: add Fluent UI theme recipe DEV-1211: docs: add Fluent UI theme recipe Apr 8, 2026
@qunabu
Copy link
Copy Markdown
Contributor Author

qunabu commented Apr 8, 2026

Task linked: DEV-1211 Fluent UI

@qunabu
Copy link
Copy Markdown
Contributor Author

qunabu commented Apr 8, 2026

cursoragent and others added 3 commits April 8, 2026 11:32
Co-authored-by: Mateusz Wojczal <qunabu@users.noreply.github.com>
Co-authored-by: Mateusz Wojczal <qunabu@users.noreply.github.com>
@qunabu qunabu self-assigned this Apr 9, 2026
@qunabu qunabu marked this pull request as ready for review April 15, 2026 10:53
@qunabu
Copy link
Copy Markdown
Contributor Author

qunabu commented Apr 15, 2026

@cursoragent the table doesn't look like one on the https://storybooks.fluentui.dev/react/?path=/docs/components-table--docs page
image

  1. change font
  2. change colors
  3. change font
  4. change paddings

@cursor
Copy link
Copy Markdown
Contributor

cursor Bot commented Apr 15, 2026

Walkthrough

Updated Fluent UI sandbox with tuned typography, colors, and paddings

Sandbox now uses a Fluent-like visual baseline (Segoe font, neutral palette, roomier spacing).

Summary

  • Applied the PR feedback directly by retuning the Fluent recipe demo styling in the embedded sandbox and in the documented theme snippet: updated font stack, foreground/background colors, header/border tones, and cell/menu/input paddings.fluent-ui.md:131-151
  • Switched the recipe iframe and “Open in CodeSandbox” link to the newly generated tuned sandbox (zjtfff).fluent-ui.md:24-32
  • Proactively updated the PR description to call out these specific visual fixes and linked artifact evidence.

Testing

  • npm install --prefix docs && npm run docs:lint --prefix docs``terminal:1-23
  • ✅ Manual browser verification of http://127.0.0.1:4321/docs/react-data-grid/recipes/themes/fluent-ui/ confirmed the embedded sandbox renders and no SSE deprecation banner appears.
  • ✅ Programmatic sandbox creation succeeded for the tuned version ({"sandbox_id":"zjtfff"}).terminal:1-3

Pushed commit: 620647303
PR: #12292

Open in Web Open in Cursor 

cursoragent and others added 2 commits April 15, 2026 11:40
Co-authored-by: Mateusz Wojczal <qunabu@users.noreply.github.com>
@qunabu qunabu requested review from GreenFlux and sl01k April 16, 2026 12:12
Copy link
Copy Markdown
Contributor

@GreenFlux GreenFlux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The install command in step 1 uses a pinned version to a canary build. It should just be:

npm install handsontable @handsontable/react-wrapper @fluentui/react-components

@qunabu qunabu merged commit 89ab9cf into develop Apr 17, 2026
32 checks passed
@qunabu qunabu deleted the feature/fluent-ui-handsontable-recipe-518e branch April 17, 2026 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants