Update License bar styles and position#12094
Draft
adrianspdev wants to merge 8 commits intodevelopfrom
Draft
Conversation
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 9b36549:
|
Contributor
|
🏗️ Preview documentation is being built/rebuilt. |
…eature/dev-issue-2805
…eature/dev-issue-2805
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Restructures the root layout: license notification, pagination, and overlay UI (dialog, empty data state) use dedicated containers. License logic moves to
utils/licenseNotificationwith focus-scope support, Dialog/EmptyDataState render into a shared overlay container.Changes
Core layout
rootAfterGridElement– New.ht-after-gridcontainer for pagination and license bar, width synced onafterRender.rootOverlaysElement– New.ht-overlayscontainer, Dialog and Empty Data State append here instead ofrootElement.after().core.js– Switched toinitLicenseNotification(instance), after-grid width updated on render for root instance.License notification
utils/licenseNotification.js(new) – Injects product info intorootAfterGridElementwhen license invalid/expired/missing, registers focus scope for notification links (Tab/Shift+Tab).utils/__tests__/licenseNotification.unit.js(new) – Tests for init, injection, focus scope, and link focus.tableView.js– RemovedaddClassNameToLicenseElement/removeClassNameFromLicenseElement, license DOM handled by license util only.Plugins
overlayContainer(rootOverlaysElement), appends viaappendChild. RemovedupdateHeight(licenseInfoHeight).afterGridElement(rootAfterGridElement), test added for width set after render.Styles
:has(> .ht-after-grid > div)for background/border-radius when after-grid has content, radius logic moved to_border-radius.scss. Updated border around wrapper..wtHolderuse CSS var, last visible column fix. New rules flatten bottom radius when license/pagination present, radius cleaned up.margin-top: 10pxand styles update.border-radiuson bar, table overrides replaced by shared.ht-root-wrapper:has(> .ht-after-grid > div)rules.Helpers
mixed.js–_injectProductInfotakes options{ className, key, element, releaseDate }and injects into givenelement.How has this been tested?
Locally, new and updated test cases
Types of changes
Related issue(s):
Affected project(s):
handsontableChecklist:
Note
Medium Risk
Changes the core DOM structure and where multiple plugin UIs (dialog, empty data state, pagination, license notice) are mounted, which can affect layout, sizing, and focus navigation across integrations. No auth/data-path changes, but UI regressions are possible due to CSS and rendering adjustments.
Overview
Reworks the Handsontable root DOM to introduce dedicated containers:
ht-overlays(for overlay-style UI like empty data state and dialogs) andht-after-grid(for pagination and the license notification), and wires plugins to mount into these containers instead of inserting adjacent toht-grid.Replaces the previous
_injectProductInfocall with a newinitLicenseNotification()utility that injects the license message into the after-grid area and registers a focus scope for its links; the after-grid container width is kept in sync onafterRender.Updates empty-data-state sizing to avoid zero-height when
height: autoand there are no rows, refreshes/adjusts pagination width/border handling, and revises CSS border-radius/background rules (including:has(...)selectors) plus tests to match the new DOM placement and license markup structure.Written by Cursor Bugbot for commit d433e61. This will update automatically on new commits. Configure here.