Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: hackmdio/codimd
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: b1188a5
Choose a base ref
...
head repository: hackmdio/codimd
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 9287f6f
Choose a head ref
  • 8 commits
  • 11 files changed
  • 1 contributor

Commits on Sep 30, 2025

  1. experiment: Add reverse proxy path rewriting testbench 

    - Add Caddyfile.experiment with path stripping configuration
- Add test script to validate the setup
- Document the experiment approach and differences from main PR

This tests if we can offload URL path handling entirely to the reverse proxy.
    @Yukaii
    Yukaii committed Sep 30, 2025
    Configuration menu
    Copy the full SHA
    aac0abc View commit details
    Browse the repository at this point in the history

  2. fix: Update Caddyfile with working route-based path rewriting 

    - Use route directive for proper request matching
- Fix redirect matchers with path_regexp for exact matching
- All tests now passing:
  ✅ Root redirect (/ → /codimd/)
  ✅ Path redirect (/codimd → /codimd/)
  ✅ Main app accessible at /codimd/
  ✅ Static assets working
  ✅ Build assets working
  ✅ Path stripping via uri strip_prefix
  ✅ X-Forwarded-Prefix header passed to app
    @Yukaii
    Yukaii committed Sep 30, 2025
    Configuration menu
    Copy the full SHA
    475178e View commit details
    Browse the repository at this point in the history

  3. docs: Update experiment README with test results 

    - Document all passing tests
- Add key learnings about Caddy configuration
- Note potential issues that need further testing
- Clarify that this approach requires reverse proxy
    @Yukaii
    Yukaii committed Sep 30, 2025
    Configuration menu
    Copy the full SHA
    8e838dc View commit details
    Browse the repository at this point in the history

  4. docs: Add comprehensive comparison of URL path approaches 

    - Compare app-based vs proxy-based path handling
- Include test results for both approaches
- Provide working Caddy and Nginx configurations
- Recommend Approach 1 (main PR) for production

This helps decide between the two architectural approaches.
    @Yukaii
    Yukaii committed Sep 30, 2025
    Configuration menu
    Copy the full SHA
    30ab797 View commit details
    Browse the repository at this point in the history

  5. experiment: Add Nginx reverse proxy configuration (WIP - networking i… 

    …ssues on macOS)

- Add nginx.experiment.conf with path rewriting
- Add docker-compose.nginx-experiment.yml
- Add test-nginx-experiment.sh test script
- Note: Encountering Docker networking issues on macOS
  - host.docker.internal works from container
  - But port 8081 times out from host
  - Caddy experiment works perfectly as reference

The configuration is correct but needs Linux Docker or different setup for macOS.
    @Yukaii
    Yukaii committed Sep 30, 2025
    Configuration menu
    Copy the full SHA
    8858ce4 View commit details
    Browse the repository at this point in the history

  6. fix: Nginx experiment now working with docker run 

    - docker-compose has networking issues on macOS
- docker run works perfectly with --add-host flag
- Added start-nginx-experiment.sh script for easy setup
- All tests passing: redirects, static assets, main app

The Nginx reverse proxy path rewriting is now fully working!
    @Yukaii
    Yukaii committed Sep 30, 2025
    Configuration menu
    Copy the full SHA
    348773c View commit details
    Browse the repository at this point in the history

  7. docs: Update comparison with working Nginx setup

    @Yukaii
    Yukaii committed Sep 30, 2025
    Configuration menu
    Copy the full SHA
    d8918a3 View commit details
    Browse the repository at this point in the history

  8. docs: Add comprehensive experiment summary 

    - Document successful Caddy and Nginx setups
- Include quick start guides
- Add comparison table and test results
- Provide recommendations for each approach
    @Yukaii
    Yukaii committed Sep 30, 2025
    Configuration menu
    Copy the full SHA
    9287f6f View commit details
    Browse the repository at this point in the history
Loading