Repository navigation
Conversation
- fix getStats age bug, reviewer buckets, cache and field aggregations - fix ensureAccountLinkedToHacker account ID comparison for resume routes - run tests with cross-env and NODE_ENV=test on npm test / test-windows - use account credentials in resume upload integration test
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes failing Mocha integration tests and related API bugs in hacker stats and resume upload authorization.
List of changes:
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Test:
cross-envsuch thatDEBUGandNODE_ENVwork on Windows.test, instead ofdevelopmentso it uses the test database.cross-envas adevDependency.Hacker stats:
GET /api/hacker/statusreturning500due to an undefinedagevariable when incrementing age counts.fieldOfStudyaggregation and guard missingdietaryRestrictions.Resume upload auth:
String(), instead ofString.toString(), so only the account linked to the hacker can upload a resume for that ID.Test:
noTeamHackerAccount0instead of the hacker fixture without email/passowrd.Type of change
How has this been tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
npm run test-windows: 171 (all) passing (took around 20 mins) on local Mongo test DBChecklist: