Skip to content

Road to 100% coverage#187

Merged
PragTob merged 7 commits intohacketyhack:masterfrom
ArturG:rspec
Mar 10, 2014
Merged

Road to 100% coverage#187
PragTob merged 7 commits intohacketyhack:masterfrom
ArturG:rspec

Conversation

@ArturG
Copy link
Copy Markdown
Contributor

@ArturG ArturG commented Mar 1, 2014

I will add more tests soon...hopefully we will get 100% coverage before next week :)

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-17.07%) when pulling 0e3bb4e on ArturG:rspec into b4f74ac on hacketyhack:master.

@PragTob
Copy link
Copy Markdown
Member

PragTob commented Mar 3, 2014

Sounds good, thank you!

The build errored due to some git error, I restarted it and here's to it passing!

Thanks for your hard work!

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same when pulling a0d2ed1 on ArturG:rspec into b4f74ac on hacketyhack:master.

@ArturG
Copy link
Copy Markdown
Contributor Author

ArturG commented Mar 4, 2014

This bot never says good things... :)

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same when pulling d39e127 on ArturG:rspec into b4f74ac on hacketyhack:master.

@ArturG
Copy link
Copy Markdown
Contributor Author

ArturG commented Mar 9, 2014

@PragTob you may merge this PR, because I'm gonna be inactive for a while (spring break, yay!). We got 99.51% coverage, however, as you may know, the 100% itself doesn't guarantee lack of bugs... we still have a lot of work to do.

@PragTob
Copy link
Copy Markdown
Member

PragTob commented Mar 9, 2014

Hey, thanks so much! I will review this shortly (if not please ping me). Enjoy your spring break! =D

PragTob added a commit that referenced this pull request Mar 10, 2014
@PragTob PragTob merged commit e1d35c0 into hacketyhack:master Mar 10, 2014
@PragTob
Copy link
Copy Markdown
Member

PragTob commented Mar 10, 2014

Thanks heaps!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants