Added tests for blog_controller and fixed a path#144
Merged
steveklabnik merged 3 commits intohacketyhack:masterfrom Feb 11, 2013
pbjorklund:blogcontroller_spec
Merged
Added tests for blog_controller and fixed a path#144steveklabnik merged 3 commits intohacketyhack:masterfrom pbjorklund:blogcontroller_spec
steveklabnik merged 3 commits intohacketyhack:masterfrom
pbjorklund:blogcontroller_spec
Conversation
Contributor
Author
|
Also it seems that hub would not let me assign this to issue 113 with -i 113, perhaps it only work on issues you already own? |
steveklabnik
added a commit
that referenced
this pull request
Feb 11, 2013
Added tests for blog_controller and fixed a path
Member
|
Thank you so much! I haven't used '-i' before, so I dunno what's up with that. Just put 'Closes #113' or whatever in your message. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems that it tries to redirect to blog_index instead of
blog_index_path which I found strange, so the tests goes against the
updated version of the blog controller which uses blog_index_path.
Now I'm no testing expert, so feel free to tell me all things I should
have done differently. This is a big part of why I wrote the tests.