Coverity fixes - #100
Merged
Merged
Conversation
If any of those ioctls fail, the returned data is undefined.
This is a false positive because the kernel does the right thing and takes UINPUT_MAX_NAME_SIZE into account. But this shuts up coverity and other static analyzers so I think we can live with a 79 character restriction instead of 80. Also change to use sizeof(), not that it really makes a difference but it allows for the array size to be changed while leaving the constant as-is, impossible as that is.
Owner
|
Much appreciated! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nothing overly exciting, the first two are obvious. The third one is optional, if you don't like it because the only effect is to shut up coverity's false positive here feel free to skip that one.