fix: Avoid Node.js deprecation warning for fs.Stats#358
Merged
Conversation
2e939dc to
a4f208c
Compare
Merged
a4f208c to
bbfde55
Compare
yocontra
approved these changes
Jun 1, 2025
|
While reviewing a dependency update for Gulp I looked into the context of the
|
|
This change broke Deno compatibility: |
Member
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Node.js core team is cruel and moves things to their
internal/package and then marks them as deprecated. We can work around this using some crazy JS techniques (seen below).When logging the new
fs.Statscreated by this technique, they look the same asnew fs.Stats()and no deprecation warning is shown.Closes #356