-
Notifications
You must be signed in to change notification settings - Fork 4k
examples: Clean up Health, and document need for grpc-services #12743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+42
−38
Merged
Changes from 1 commit
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
examples: Clean up Health, and document need for grpc-services
For something like this, putting all the config together in service config is what we would want to encourage. Remove unused/needless variables. Emphasize health checking more than round-robin. Add missing synchronization on server-side.
- Loading branch information
commit 0a494caf82c2273eaf77091d381993478068f0e3
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 changes: 6 additions & 3 deletions
9
examples/src/main/java/io/grpc/examples/healthservice/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,13 @@ | ||
| gRPC Health Service Example | ||
| ===================== | ||
|
|
||
| The Health Service example provides a HelloWorld gRPC server that doesn't like short names along with a | ||
| health service. It also provides a client application which makes HelloWorld | ||
| calls and checks the health status. | ||
| The Health Service example provides a HelloWorld gRPC server that doesn't like | ||
| short names along with a health service. It also provides a client application | ||
| which makes HelloWorld calls and checks the health status. | ||
|
|
||
| The client application also shows how the round robin load balancer can | ||
| utilize the health status to avoid making calls to a service that is | ||
| not actively serving. | ||
|
|
||
| Note that clients must depend on `io.grpc:grpc-services` for the health-aware | ||
| round_robin implementation to be used. |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.