Skip to content

Enlightenment support for python2 at Travis-CI - #41

Merged
gregmalcolm merged 9 commits into
gregmalcolm:masterfrom
brainstorm:master
Feb 15, 2013
Merged

Enlightenment support for python2 at Travis-CI#41
gregmalcolm merged 9 commits into
gregmalcolm:masterfrom
brainstorm:master

Conversation

@brainstorm

Copy link
Copy Markdown
Contributor
  • Proof of concept with python2 koans and Travis-CI

For a (still damaged) karma see: https://travis-ci.org/brainstorm/python_koans/builds/4752639
For expanded awareness check: https://travis-ci.org/brainstorm/python_koans/builds/4763598

@brainstorm

Copy link
Copy Markdown
Contributor Author

Well, you will have to cherry pick commits and disregard "03c0352" since it solves the about_asserts_koan...

@gregmalcolm

Copy link
Copy Markdown
Owner

Love what you guys are doing here!

But need AboutAsserts to reset to original failing state before I can pull this into the main fork

(so I can auto-merge the commits from web interface)

gregmalcolm added a commit that referenced this pull request Feb 15, 2013
Enlightenment support for python2 at Travis-CI
@gregmalcolm
gregmalcolm merged commit e2bd99a into gregmalcolm:master Feb 15, 2013
@gregmalcolm

Copy link
Copy Markdown
Owner

Thanks! Turns out I had to get on my machine anyway to look through this. I merged in the change but I was noticed a couple of problems:

  1. Running contemplate_koans without arguments was resulting in no output. I think it might have been a side effect of the tab spacing being a little out of whack. I've turned all the endenting back to spaces so that should be fine now.

  2. I tweaked the multi-arguments code so that it runs all the specified tests as one suite of tests rather that a series of suites. That way you won't have that message about completing the koans showing up after each koan file is completed.

That work for you?

@brainstorm

Copy link
Copy Markdown
Contributor Author

Indeed, push it please! Sorry for those, my vim has some settings that do not play well with your codebase, my bad :_/

And yeah, I noticed the completing koans message, I pushed that code just minutes before I told the whole class to fork my repo, I needed something working fast and didn't pay attention to corner cases.

Thanks Greg!

@brainstorm

Copy link
Copy Markdown
Contributor Author

Just saw your commit, thanks ;)

@gregmalcolm

Copy link
Copy Markdown
Owner

Heh, no problem. All the coolest changes are made minutes before a class starts... :D

I noticed some of the python_koans builds flying by in Travis. That's awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants