Skip to content

Call 'a' global method, not 'an' global method. Python3 had it right. #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gregmalcolm merged 2 commits into from
Jul 29, 2012
Merged

Call 'a' global method, not 'an' global method. Python3 had it right. #20

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ef36871
Call 'a' global method, not 'an' global method. Python3 had it right.
mikelietz Jul 29, 2012
20811df
A one line method should be one line, right? Python3 had it right.
mikelietz Jul 29, 2012
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions python2/koans/about_methods.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ def my_global_function(a, b):


class AboutMethods(Koan):
def test_calling_an_global_function(self):
def test_calling_a_global_function(self):
self.assertEqual(__, my_global_function(2, 3))

# NOTE: Wrong number of arguments is not a SYNTAX error, but a
Expand Down Expand Up @@ -113,8 +113,7 @@ def test_pass_does_nothing_at_all(self):

# ------------------------------------------------------------------

def one_line_method(self):
return 'Madagascar'
def one_line_method(self): return 'Madagascar'

def test_no_indentation_required_for_one_line_statement_bodies(self):
self.assertEqual(__, self.one_line_method())
Expand Down