Update about_new_style_classes.py#148
Merged
Merged
Conversation
change __class__ to __class__.__name__ in line 49
Collaborator
|
It looks like the intention here was to demonstrate that with the advent of new-style classes, types and classes were unified (see https://www.python.org/download/releases/2.2.3/descrintro/). The passing test case that shows this would be:
It's probably a good idea to add a comment here to make this clearer. I'll give it a try and see if I can word it decently without giving it all away. |
Collaborator
|
Actually I have a problem with my brain being missing. Sorry! Reopening and merging this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
change class to class.name in line 49