Fixes #137: test_everything_else_is_treated_as_true - #142
Merged
Conversation
In the Python 2 and 3 versions of koans/about_true_and_false.py: self.truth_value(1,) is an integer argument followed by an optional comma. It just happened to produce the desired answer, because bool(1) is True. self.truth_value((1,)) is a tuple argument. Changed the tuple to (0,) to demonstrate that its truthiness comes from the presence of _any_ elements, and not from the truth value of the element itself. Also, added an easier example before it --- self.truth_value([0]) --- to introduce the same idea with the simpler list-literal syntax (no "magic" comma to worry about). Finally, changed the whitespace and line wrapping so the Python 2 and 3 files are identical. Reported by: egonluo https://github.com/egonluo Issue gregmalcolm#137: gregmalcolm#137
Collaborator
|
@kjc: Kevin, thanks for all the PRs this week! I hope to check them out in the next day or so and get them landed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #137
In the Python 2 and 3 versions of koans/about_true_and_false.py:
self.truth_value(1,) is an integer argument followed by an optional
comma. It just happened to produce the desired answer, because bool(1)
is True.
self.truth_value((1,)) is a tuple argument. Changed the tuple to (0,)
to demonstrate that its truthiness comes from the presence of any
elements, and not from the truth value of the element itself.
Also, added an easier example before it --- self.truth_value([0]) ---
to introduce the same idea with the simpler list-literal syntax (no
"magic" comma to worry about).
Finally, changed the whitespace and line wrapping so the Python 2 and 3
files are identical.
Reported by: egonluo
https://github.com/egonluo
Issue #137:
#137