Repository navigation
Rework input parsing in MethodFieldResolver to handle scalars within input objects - #471
Closed
oryan-block wants to merge 3 commits into
Closed
oryan-block wants to merge 3 commits into
oryan-block wants to merge 3 commits into
Conversation
oryan-block
commented
Jan 5, 2021
vojtapol
requested changes
Jan 7, 2021
vojtapol
left a comment
Member
There was a problem hiding this comment.
While this solves the issue getting rid of Jackson completely might be too big of a breaking change. I would recommend finding a specific workaround for the Upload scalar for now and then come back to this in the future.
vojtapol
marked this pull request as draft
January 7, 2021 17:13
Collaborator
Author
|
Closing for now since we have a workaround: #466 (comment) |
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #466
Checklist
Description
Since there is no way for Jackson to know how to handle custom scalar types I have chosen to re-implement the input parsing manually. While this means we can't rely on Jackson to parse simple POJOs for us it also means we have more control over what's going on and we can handle the hard parts directly.
What this is doing is recursively building the java type from the given input value according to the graphql schema.