Repository navigation
Fixes #198 - Add support for lists of Scalar field arguments that are already coerced - #320
Merged
oliemansm merged 1 commit intoNov 14, 2019
Conversation
…d arguments that are already coerced graphql-java already converts scalar types and lists of scalar types when used as field arguments. However the MethodFieldResolver basically serialized that object and deserialized the value to use it as argument value while it's not really necessary. The serialization/deserialization also failed when the (Java) type of the scalar is not easily serializable/deserializable (for example with private fields)
arian
force-pushed
the
198-scalar-input-types
branch
from
October 10, 2019 13:22
abd4e66 to
44fdca1
Compare
|
This seems to not work when the input argument is non-nullable, for example:
is correctly coerced, but then passed to Jackson converter. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #198
graphql-java already converts scalar types and lists of scalar types
when used as field arguments.
However the MethodFieldResolver basically serialized that object and
deserialized the value to use it as argument value while it's not really
necessary.
The serialization/deserialization also failed when the (Java) type of the
scalar is not easily serializable/deserializable (for example with
private fields)