Fix Query Caching section so that example code compiles#160
Merged
Conversation
Member
|
Thanks so much for contributing, and thanks for also making the change for the versioned doc. Sorry it took a while to reply! Leaving a breadcrumb: this is the commit with the change in GraphQL Java graphql-java/graphql-java@0b957bb |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version 22.0 of
graphql-javaremoved a deprecated method from thePreparsedDocumentProviderinterface.This means that the example code for setting up a Query Cache, which used the deprecated method, no longer compiles.
This PR updates the documentation so that it will compile.
Note that I'm not sure whether there's a better solution than using
CompletableFuture.completedFuture(), so open to suggestions.