Added schema / introspection diff support#745
Merged
Conversation
Member
|
I this a direct adaption of the graphql-js implementation: https://github.com/graphql/graphql-js/blob/26023b30ff8dd083bdf60f2415909f18ebdda502/src/utilities/findBreakingChanges.js ? |
andimarek
approved these changes
Oct 1, 2017
| } | ||
|
|
||
| @SuppressWarnings("ConstantConditions") | ||
| private Optional<SchemaDefinition> getSchemaDef(Document document) { |
Member
There was a problem hiding this comment.
maybe it is better to throw an exception if no SchemaDefinition can be found?
Member
Author
No its not. Its was developed indepedently pretty much |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see #744
Adds support for diffing two schemas or introspection results