Improving exception for duplicated field definition#714
Merged
andimarek merged 2 commits intoSep 17, 2017
Merged
Conversation
andimarek
requested changes
Sep 16, 2017
Member
andimarek
left a comment
There was a problem hiding this comment.
Hi,
thanks for your PR. Looks goods except the removed empty javadoc lines.
Thank you!
| * from within | ||
| * | ||
| * @param builder an un-built/incomplete GraphQLFieldDefinition | ||
| * |
Member
There was a problem hiding this comment.
could you please not remove this extra line?
| * </pre> | ||
| * | ||
| * @param builderFunction a supplier for the builder impl | ||
| * |
Member
There was a problem hiding this comment.
could you please not remove this extra line?
Contributor
Author
|
No worries, I can add them back. I just followed the other files format which seems to be aligned with java standards better. |
- Adding javadoc empty line back
Member
|
thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At first, I found difficult to understand what the exception meant and where to find the problem to fix. So, I'm providing clearer description for that. Supposing the following schema:
We'll get the following exception:
Current:
Exception in thread "main" graphql.AssertException: field password redefinedUpdate:
Exception in thread "main" graphql.AssertException: Duplicated definition for field 'password' in type 'User'