graphql.execute can accept a builder#551
Merged
Merged
Conversation
…o the `graphql.execute()` method
…uilder # Conflicts: # src/main/java/graphql/GraphQL.java # src/test/groovy/graphql/GraphQLTest.groovy
bbakerman
commented
Jul 5, 2017
| * @deprecated Use {@link #execute(ExecutionInput)} | ||
| */ | ||
| @Deprecated | ||
| public ExecutionResult execute(String query) { |
Member
Author
There was a problem hiding this comment.
This is one contentious aspect of this PR.
The most basic way to execute a query (just the string) was deprecated.
50 of our tests are now invalid. It tells me that we need a simple bit of sugar to allow an easy way to get going and then have the ExecutionInput as the way to do it in a more complex way.
Member
There was a problem hiding this comment.
yes, I totally agree: execute(String) should not be deprecated
bbakerman
commented
Jul 5, 2017
| def builderFunction = { it.query('{hello}')} as UnaryOperator<ExecutionInput.Builder> | ||
| def result = GraphQL.newGraphQL(schema).build().execute(builderFunction).data | ||
|
|
||
| then: |
Member
Author
There was a problem hiding this comment.
groovy and java closures are not so sweet :(
andimarek
requested changes
Jul 5, 2017
andimarek
left a comment
Member
There was a problem hiding this comment.
In general of course totally ok, but we do now have in addition executeAsync, and we should support everything for that method too.
| def builderFunction = { it.query('{hello}')} as UnaryOperator<ExecutionInput.Builder> | ||
| def result = GraphQL.newGraphQL(schema).build().execute(builderFunction).data | ||
|
|
||
| then: |
…uilder # Conflicts: # src/test/groovy/graphql/GraphQLTest.groovy
removed some Idea warnings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Like the other parts of the code that use a builder, it now takes one as input plus used the builder function pattern