Skip to content

Recursively adding input types#48

Merged
andimarek merged 1 commit into
graphql-java:masterfrom
davidscottcohen:bugfix/nested-input-types
Nov 15, 2015
Merged

Recursively adding input types#48
andimarek merged 1 commit into
graphql-java:masterfrom
davidscottcohen:bugfix/nested-input-types

Conversation

@davidscottcohen
Copy link
Copy Markdown

No description provided.

@davidscottcohen
Copy link
Copy Markdown
Author

Oh, editor dropped some crap we don't want, will resubmit

@davidscottcohen davidscottcohen force-pushed the bugfix/nested-input-types branch from e55f547 to eb03f49 Compare November 12, 2015 00:19
@andimarek
Copy link
Copy Markdown
Member

Thanks for this PR!

Do I understand this correct that this is BugFix and currently input types are not collected when they are not top level input types in the Schema?

@davidscottcohen
Copy link
Copy Markdown
Author

Your understanding is correct. The unit test I included in SchemaUtilTest will fail if you undo my change to SchemaUtil (it won't get the Range type).

@andimarek
Copy link
Copy Markdown
Member

Thanks .... I merge it.

@andimarek andimarek closed this Nov 15, 2015
@andimarek andimarek reopened this Nov 15, 2015
andimarek added a commit that referenced this pull request Nov 15, 2015
@andimarek andimarek merged commit e74f7f6 into graphql-java:master Nov 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants